gaurav-narula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473758133
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -4912,7 +4919,9 @@ class ReplicaManagerTest {
assertTrue(fooPart eq fooPart2)
val bar1 = new TopicPartition("bar", 1)
replicaManager.markPartitionOffline(bar1)
- assertEquals(None, replicaManager.getOrCreatePartition(bar1, emptyDelta,
BAR_UUID))
+ val (barPart, barNew) = replicaManager.getOrCreatePartition(bar1,
emptyDelta, BAR_UUID).get
+ assertTrue(barNew)
+ assertEquals(bar1, barPart.topicPartition)
Review Comment:
Addressed in
[cdf9c0f](https://github.com/apache/kafka/pull/15263/commits/cdf9c0f0cf817e68ca27092addb21308a9bc3762)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
