cmccabe commented on PR #15287: URL: https://github.com/apache/kafka/pull/15287#issuecomment-1922552107
I'm sorry but I had to revert this. It's just not correct. * Brokers don't need to be in "pure ZK mode" to become ZK controllers. A broker with `zookeeper.metadata.migration.enable = true` but running in hybrid ZK mode can become a ZK-based controller if the `/controller` znode is vacant. * running zookeeper-shell.sh does *not* need to be done "quickly together with rolling at least one broker". You must have all brokers in hybrid ZK mode before deleting the `/controller` znode. Note: If you want to submit a separate PR removing the advice to change `node.id` to `broker.id`, that would be fine. That is not strictly necessary so removing from the docs it is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
