dengziming commented on code in PR #15304:
URL: https://github.com/apache/kafka/pull/15304#discussion_r1475729209
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -349,7 +349,7 @@ object ConfigCommand extends Logging {
}
@nowarn("cat=deprecation")
- private[admin] def alterConfig(adminClient: Admin, opts:
ConfigCommandOptions): Unit = {
+ private[admin] def alterConfig(adminClient: Admin, opts:
ConfigCommandOptions, useIncrementalAlterConfigs: Boolean): Unit = {
Review Comment:
Good catch, I added a case of updating broker configs with
`useIncrementalAlterConfigs=false`, also add a case of updating topic configs
which only support `incrementalAlterConfigs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
