yashmayya commented on code in PR #15302:
URL: https://github.com/apache/kafka/pull/15302#discussion_r1475872307


##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##########
@@ -801,6 +806,11 @@ public void testResetSinkConnectorOffsetsZombieSinkTasks() 
throws Exception {
         
connect.assertions().assertConnectorAndAtLeastNumTasksAreRunning(connectorName, 
1,
                 "Connector tasks did not start in time.");
 
+        // Make sure the tasks' consumers have had a chance to actually form a 
group
+        // (otherwise, the reset request will succeed because there won't be 
any active consumers)
+        verifyExpectedSinkConnectorOffsets(connectorName, topic, 1, 
NUM_RECORDS_PER_PARTITION,

Review Comment:
   Looks like this test was already verifying this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to