appchemist commented on code in PR #15225:
URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608
##########
core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala:
##########
@@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends
QuorumTestHarness with Logging {
fetcher1.close()
}
- @Test
- def shouldIncreaseLeaderEpochBetweenLeaderRestarts(): Unit = {
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def shouldIncreaseLeaderEpochBetweenLeaderRestarts(quorum: String): Unit = {
//Setup: we are only interested in the single partition on broker 101
- brokers += createServer(fromProps(createBrokerConfig(100, zkConnect)))
- assertEquals(100, TestUtils.waitUntilControllerElected(zkClient))
+ brokers += createBroker(fromProps(createBrokerConfig(100,
zkConnectOrNull)))
+ if (!isKRaftTest()) {
Review Comment:
Of course, I will.
I checked the leader election using `KafkaRaftManager` in KRaft Mode. Is
this a good approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
