dajac commented on code in PR #15348:
URL: https://github.com/apache/kafka/pull/15348#discussion_r1486181764
##########
checkstyle/suppressions.xml:
##########
@@ -336,11 +336,11 @@
<suppress checks="CyclomaticComplexity"
files="(ConsumerGroupMember|GroupMetadataManager|GeneralUniformAssignmentBuilder).java"/>
<suppress checks="(NPathComplexity|MethodLength)"
-
files="(GroupMetadataManager|ConsumerGroupTest|GroupMetadataManagerTest|GeneralUniformAssignmentBuilder).java"/>
+
files="(GroupMetadataManager|ConsumerGroupTest|GroupMetadataManagerTest|GroupMetadataManagerTestContext|GeneralUniformAssignmentBuilder).java"/>
Review Comment:
I was actually not aware of this. I think that it makes sense. I file
https://issues.apache.org/jira/browse/KAFKA-16244 to give it a try. In this PR,
I would prefer to keep the `suppressions.xml` exception though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
