msn-tldr commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1486583557
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##########
@@ -879,17 +884,12 @@ private List<ProducerBatch>
drainBatchesForOneNode(Metadata metadata, Node node,
// Only proceed if the partition has no in-flight batches.
if (isMuted(tp))
continue;
- Metadata.LeaderAndEpoch leaderAndEpoch =
metadata.currentLeader(tp);
- // Although a small chance, but skip this partition if leader has
changed since the partition -> node assignment obtained from outside the loop.
Review Comment:
Correct, since snapshot is immutable & race condition is not possible, hence
removed the code & comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
