CalvinConfluent commented on code in PR #14604:
URL: https://github.com/apache/kafka/pull/14604#discussion_r1486709516
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##########
@@ -124,6 +124,8 @@ Optional<CompletedReassignment>
maybeCompleteReassignment(List<Integer> targetIs
if (!newTargetIsr.contains(replica)) return Optional.empty();
}
+ if (newTargetIsr.size() < Math.min(minIsrCount,
newTargetReplicas.size())) return Optional.empty();
Review Comment:
@jolshan You are right. The newTargetReplicas is the expected target set.
The math.min thing mainly prevents the reassignment from stuck because of a
high minISR by mistake. (We do not have any sanity checks when setting the
minISR config.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
