CalvinConfluent commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488779105
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##########
@@ -120,9 +120,7 @@ Optional<CompletedReassignment>
maybeCompleteReassignment(List<Integer> targetIs
}
if (newTargetReplicas.isEmpty()) return Optional.empty();
}
- for (int replica : adding) {
- if (!newTargetIsr.contains(replica)) return Optional.empty();
Review Comment:
Yes, the replica is the original replica + adding replica. Double-checked in
UT debug mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
