mumrah commented on code in PR #15366:
URL: https://github.com/apache/kafka/pull/15366#discussion_r1489893040
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -197,13 +209,15 @@ private MetadataLoader(
String threadNamePrefix,
FaultHandler faultHandler,
MetadataLoaderMetrics metrics,
- Supplier<OptionalLong> highWaterMarkAccessor
+ Supplier<OptionalLong> highWaterMarkAccessor,
+ Supplier<LeaderAndEpoch> leaderAndEpochAccessor
) {
this.log = logContext.logger(MetadataLoader.class);
this.time = time;
this.faultHandler = faultHandler;
this.metrics = metrics;
this.highWaterMarkAccessor = highWaterMarkAccessor;
+ this.leaderAndEpochAccessor = leaderAndEpochAccessor;
Review Comment:
Should we call this "initialLeaderAndEpochAccessor" since we only read from
it during startup? Otherwise it might be confusing that we have this supplier,
but update the `currentLeaderAndEpoch` in a different way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
