dajac commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1492587334
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##########
@@ -251,195 +255,51 @@ private ConsumerGroupMember
transitionToNewTargetAssignmentState() {
}
if (!newPartitionsPendingRevocation.isEmpty()) {
- // If the partition pending revocation set is not empty, we
transition the
- // member to revoking and keep the current epoch. The transition
to the new
- // state is done when the member is updated.
+ // If there are partitions to be revoked, the member remains in
its current
+ // epoch and requests the revocation of those partitions. It
transitions to
+ // the UNREVOKED_PARTITIONS state to wait until the client
acknowledges the
+ // revocation of the partitions.
return new ConsumerGroupMember.Builder(member)
+ .setState(MemberState.UNREVOKED_PARTITIONS)
+ .updateMemberEpoch(memberEpoch)
.setAssignedPartitions(newAssignedPartitions)
- .setPartitionsPendingRevocation(newPartitionsPendingRevocation)
- .setPartitionsPendingAssignment(newPartitionsPendingAssignment)
- .setTargetMemberEpoch(targetAssignmentEpoch)
+ .setRevokedPartitions(newPartitionsPendingRevocation)
Review Comment:
Alright. Let me change it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
