florin-akermann commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1492958285
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##########
@@ -191,6 +191,10 @@ public void process(final Record<K, V1> record) {
}
}
+ private boolean isActiveWindow(final long timeFrom, final long timeTo)
{
+ return sharedTimeTracker.streamTime >= timeFrom && timeTo +
joinGraceMs >= sharedTimeTracker.streamTime;
Review Comment:
yes, indeed, it is redundant to check for `sharedTimeTracker.streamTime >=
timeFrom`
adjusted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
