ahmedsobeh opened a new pull request, #15389: URL: https://github.com/apache/kafka/pull/15389
- Removed the connector field. - The class had a mix of Mock annotations and mock(Class) invocations, cleaned up one of them - The test doesn't stop the thread pool created inside the herder and might leak threads, added herder stopping in tearDown - Mocking for Worker#startConnector is 6 lines which are duplicated 8 times throughout the test, extracted to a method - Some waits are 1000 ms and others are 1000 s, and could be pulled out to constants or a util method. unified and set to a constant *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
