mjsax commented on code in PR #15396:
URL: https://github.com/apache/kafka/pull/15396#discussion_r1496379447
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##########
@@ -264,7 +264,6 @@ public void put(final Bytes key,
final S segment = segments.getOrCreateSegmentIfLive(segmentId,
context, observedStreamTime);
if (segment == null) {
expiredRecordSensor.record(1.0d, context.currentSystemTimeMs());
- LOG.warn("Skipping record for expired segment.");
Review Comment:
I don't see much value? We don't log any detailed information... -- the log
line only gives you a processing time timestamp but nothing more...
If we would want to make it useful, we could add offset/timestamp metadata
(but not log key/value as we never log data...) -- for this case, it might be
useful to keep at DEBUG or TRACE.
Let's hear from others about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
