lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499894219
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -215,6 +216,7 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
}
NetworkClientDelegate.UnsentRequest request =
makeHeartbeatRequest(currentTimeMs, false);
+ membershipManager.onHeartbeatRequestSent();
Review Comment:
yes, makes sense, done. I had considered it but wasn't convinced thinking
that it would complicate the leaving on the membershipMgr, but with your
comment I took another round and it does seem better actually, just a single
leaving, that in some cases is due to poll timer expired (and that allows the
manager to make the right transitions after leaving).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
