apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500028907
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+ // Visible for testing
+ final class ClientMetricsStats {
+
+ private static final String GROUP_NAME = "ClientMetrics";
+
+ // Visible for testing
+ static final String INSTANCE_COUNT = "ClientMetricsInstanceCount";
Review Comment:
@junrao Thanks for bringing this up. I did look into the naming for metrics
and found it's kind of mixed in Kafka as of now. I have attached below 2
screenshots from what I see in JMX from `kafka.server` metrics itself. I myself
was thinking that if there is some guidelines for the new metrics we follow.
<img width="425" alt="Screenshot 2024-02-22 at 10 41 08 PM"
src="https://github.com/apache/kafka/assets/2861565/8435d2ff-a4cc-40e0-93c2-e06ee317fb4f";>
<img width="341" alt="Screenshot 2024-02-22 at 10 41 16 PM"
src="https://github.com/apache/kafka/assets/2861565/0363ff09-0dc1-48d6-80de-c112a4da3ba1";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
