cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504623635
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -1372,4 +1373,8 @@ public PollResult poll(final long currentTimeMs) {
}
return PollResult.EMPTY;
}
+
+ List<MemberStateListener> stateListeners() {
Review Comment:
I do not see big value for the reader. As always, I see the risk that
eventually the method is not only used for testing and then we have a lying
comment in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
