appchemist commented on PR #15388: URL: https://github.com/apache/kafka/pull/15388#issuecomment-1975501619
@chia7712 Thanks for review! This comment is added by https://github.com/apache/kafka/pull/12862 The method with the comment was originally named `updateLastSend`, but its name was later changed to `onSendAttempt`. This method doesn't increment `numAttempts`. It seems that the `numAttempts` is only modified when a Request succeeds or fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org