cadonna commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1510774397
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ########## @@ -2403,15 +2383,18 @@ public void shouldCloseActiveTasksWhenHandlingLostTasks() throws Exception { when(activeTaskCreator.createTasks(any(), Mockito.eq(taskId00Assignment))).thenReturn(singletonList(task00)); when(standbyTaskCreator.createTasks(taskId01Assignment)).thenReturn(singletonList(task01)); - makeTaskFolders(taskId00.toString(), taskId01.toString()); + final ArrayList<TaskDirectory> taskFolders = new ArrayList<>(2); + taskFolders.add(new TaskDirectory(testFolder.newFolder(taskId00.toString()), null)); + taskFolders.add(new TaskDirectory(testFolder.newFolder(taskId01.toString()), null)); + + when(stateDirectory.listNonEmptyTaskDirectories()) + .thenReturn(taskFolders) + // The second attempt will return empty tasks. Review Comment: nit: This comment is not needed. Please remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org