lucasbru commented on PR #15437: URL: https://github.com/apache/kafka/pull/15437#issuecomment-1976699674
Hi @philipnee > Hi @lucasbru - Thanks for the PR. I think it would be good to test if all commit API throws the fenced exception. I believe async commit has already been tested, but I don't see one for commit sync. Would you mind checking the test cases for these three APIs and make sure they throw this exception? I did not implement it here because the ticket was about commitAsync. But why not, done. > Aside from that: I also see `updateAssignmentMetadataIfNeeded` throws fenced exception. Can we also check that? This doesn't seem to be used publicly, so I wouldn't consider it interface surface that we need to cover. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
