mjsax commented on PR #15395: URL: https://github.com/apache/kafka/pull/15395#issuecomment-1977688896
> Another point, I think there are some missing tests in the foreignkeyjoin package, and problems in naming a test class. For example, ForeignTableJoinProcessorSupplierTest is not testing ForeignTableJoinProcessorSupplier but SubscriptionJoinProcessorSupplier. Hence, I think the ForeignTableJoinProcessorSupplier is not tested. Thanks for pointing this out. Would you like to do a follow up PR and rename the test? And maybe also close this test gap (of not, we can also just file a ticket for this for now.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
