KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512897988


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##########
@@ -431,6 +432,7 @@ public interface LiteralSupplier<T> {
      * @param args the arguments
      */
     public static void main(String[] args) {
+        LogManager.shutdown();

Review Comment:
   After executing those tasks, I think they don't have similar issue and the 
logger implementation couldn't be loaded
   ```
   SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   ```
   And I think it's because their classpath set to the 
`sourceSets.main.runtimeClasspath` so instead of close the logger directly I 
would leverage this to eliminate unexpected log info
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to