dongnuo123 commented on code in PR #15467: URL: https://github.com/apache/kafka/pull/15467#discussion_r1512942687
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ########## @@ -901,7 +901,7 @@ public RebalanceResult staticMembersJoinAndRebalance( public PendingMemberGroupResult setupGroupWithPendingMember(ClassicGroup group) throws Exception { // Add the first member JoinGroupRequestData joinRequest = new JoinGroupRequestBuilder() - .withGroupId("group-id") + .withGroupId(group.groupId()) Review Comment: The group id is not a parameter of the method, so I guess it's fine to use `"group-id` ########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ########## @@ -901,7 +901,7 @@ public RebalanceResult staticMembersJoinAndRebalance( public PendingMemberGroupResult setupGroupWithPendingMember(ClassicGroup group) throws Exception { // Add the first member JoinGroupRequestData joinRequest = new JoinGroupRequestBuilder() - .withGroupId("group-id") + .withGroupId(group.groupId()) Review Comment: The group id is not a parameter of the method, so I guess it's fine to use `"group-id"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org