Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1519707860
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1730,6 +1744,21 @@ private void subscribeInternal(Pattern pattern,
Optional<ConsumerRebalanceListen
}
}
+ private void subscribeInternal(SubscriptionPattern pattern,
Optional<ConsumerRebalanceListener> listener) {
+ acquireAndEnsureOpen();
+ try {
+ maybeThrowInvalidGroupIdException();
+ if (pattern == null || pattern.pattern().isEmpty())
+ throw new IllegalArgumentException("Topic pattern to subscribe
to cannot be " + (pattern == null ?
+ "null" : "empty"));
+ throwIfNoAssignorsConfigured();
Review Comment:
The function call is not needed, I'll remove it. From the KIP, I don't see
the new pattern subscription can be used with a consumer-side assignor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
