showuon commented on code in PR #15505:
URL: https://github.com/apache/kafka/pull/15505#discussion_r1520960222
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -139,7 +139,7 @@ object StorageTool extends Logging {
action(storeTrue())
formatParser.addArgument("--release-version", "-r").
action(store()).
- help(s"A KRaft release version to use for the initial metadata version.
The minimum is 3.0, the default is
${MetadataVersion.LATEST_PRODUCTION.version()}")
+ help(s"A KRaft release version to use for the initial metadata.version.
The minimum is ${MetadataVersion.IBP_3_0_IV0}, the default is
${MetadataVersion.LATEST_PRODUCTION.version()}")
Review Comment:
I saw 2 formats: `MetadataVersion.IBP_3_0_IV0` and
`MetadataVersion.IBP_3_0_IV0.version()` here. Could you help me understand what
output it will be for each of them? And I think we should make them consistent.
Same as other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
