dajac commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520969629
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
buildRequestData() {
// MemberEpoch - always sent
data.setMemberEpoch(membershipManager.memberEpoch());
- // InstanceId - only sent if has changed since the last heartbeat
- // Always send when leaving the group as a static member
+ // InstanceId - send when leaving the group as a static member
membershipManager.groupInstanceId().ifPresent(groupInstanceId -> {
Review Comment:
The field is at minimum also required in the first request too. Overall, I
think that we should just set it all the time if `groupInstanceId` is defined.
This is actually was the server expects in the current implementation. We may
be able to relax this requirement in the future though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
