OmniaGM commented on code in PR #15506:
URL: https://github.com/apache/kafka/pull/15506#discussion_r1521506327


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##########
@@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {
 
         workerTask.initialize(TASK_CONFIG);
         workerTask.initializeAndStart();
-        try {
-            workerTask.execute();
-            fail("workerTask.execute should have thrown an exception");
-        } catch (ConnectException e) {
-            assertSame("Exception from put should be the cause", putException, 
e.getCause());
-            assertTrue("Exception from close should be suppressed", 
e.getSuppressed().length > 0);
-            assertSame(closeException, e.getSuppressed()[0]);
-        }
+
+        Throwable thrownException = assertThrows(ConnectException.class, () -> 
workerTask.execute());
+        assertSame("Exception from put should be the cause", putException, 
thrownException.getCause());

Review Comment:
   While `assertSame` and `assertEquals` behave the same when the default 
equals implementation is provided (which compare references)  but I'm curious 
why are we opting in for `assertSame` over `assertEquals`. Do we need the test 
to explicitly comparing object reference or just value? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to