jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1521679508
########## core/src/main/scala/kafka/server/ReplicaManager.scala: ########## @@ -1007,7 +1010,8 @@ class ReplicaManager(val config: KafkaConfig, transactionalId, producerId, producerEpoch, - generalizedCallback + generalizedCallback, + ApiKeys.PRODUCE.latestVersion Review Comment: What if we send a offset commit request that can't yet handle the error. I think we may need a different data structure. Maybe something like enums to handle the various versions 0 -- default, 1 -- new error, 2 -- add partitions rather than verifying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org