chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1522051894


##########
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##########
@@ -243,33 +243,20 @@ public MemoryRecords build() {
     /**
      * Get the max timestamp and its offset. The details of the offset 
returned are a bit subtle.
      *
-     * If the log append time is used, the offset will be the last offset 
unless no compression is used and

Review Comment:
   Could you please update `OffsetSpec` also? 
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java#L65



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to