mimaison commented on code in PR #15295:
URL: https://github.com/apache/kafka/pull/15295#discussion_r1522868135
##########
core/src/test/scala/unit/kafka/server/epoch/EpochDrivenReplicationProtocolAcceptanceTest.scala:
##########
@@ -130,15 +144,22 @@ class EpochDrivenReplicationProtocolAcceptanceTest
extends QuorumTestHarness wit
assertEquals(java.util.Arrays.asList(new EpochEntry(0, 0), new
EpochEntry(1, 1), new EpochEntry(2, 2)), epochCache(follower).epochEntries)
}
- @Test
- def shouldNotAllowDivergentLogs(): Unit = {
+
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def shouldNotAllowDivergentLogs(quorum: String): Unit = {
+ if (quorum == "kraft" && metadataVersion.isLessThan(IBP_3_3_IV0)) {
Review Comment:
Why is this metadata check needed? can you explain it?
##########
core/src/test/scala/unit/kafka/server/epoch/EpochDrivenReplicationProtocolAcceptanceTest.scala:
##########
@@ -53,17 +58,26 @@ class EpochDrivenReplicationProtocolAcceptanceTest extends
QuorumTestHarness wit
val topic = "topic1"
val msg = new Array[Byte](1000)
val msgBigger = new Array[Byte](10000)
- var brokers: Seq[KafkaServer] = _
+ var brokers: Seq[KafkaBroker] = _
var producer: KafkaProducer[Array[Byte], Array[Byte]] = _
var consumer: Consumer[Array[Byte], Array[Byte]] = _
+ private def securityProtocol: SecurityProtocol = SecurityProtocol.PLAINTEXT
+ private def listenerName: ListenerName =
ListenerName.forSecurityProtocol(securityProtocol)
+
@BeforeEach
override def setUp(testInfo: TestInfo): Unit = {
+ if (TestInfoUtils.isKRaft(testInfo)) {
Review Comment:
Why are we not running `setUp()` in KRaft mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
