dongnuo123 commented on code in PR #15528:
URL: https://github.com/apache/kafka/pull/15528#discussion_r1523584782
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -593,7 +595,8 @@ public List<DescribeGroupsResponseData.DescribedGroup>
describeGroups(
*/
ConsumerGroup getOrMaybeCreateConsumerGroup(
String groupId,
- boolean createIfNotExists
+ boolean createIfNotExists,
+ boolean addToGroupsMap
Review Comment:
Yeah, you're right. I added the flag to reduce redundancy but it does bring
risk of misusing... Let me change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
