jsancio commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1523954492
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -348,14 +357,15 @@ final class KafkaMetadataLog private (
snapshotId.offset <= latestSnapshotId.offset &&
log.maybeIncrementLogStartOffset(snapshotId.offset,
LogStartOffsetIncrementReason.SnapshotGenerated) =>
// Delete all segments that have a "last offset" less than the log
start offset
- log.deleteOldSegments()
+ val deletedSegments = log.deleteOldSegments()
// Remove older snapshots from the snapshots cache
- (true, forgetSnapshotsBefore(snapshotId))
+ val forgottenSnapshots = forgetSnapshotsBefore(snapshotId)
+ (deletedSegments != 0 || forgottenSnapshots.nonEmpty,
forgottenSnapshots)
Review Comment:
The old code was probably correct in practice. I just wanted to make clearer
that either one could be true for this function to return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
