chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524078277
##########
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##########
@@ -35,24 +35,12 @@ public class BoundedList<E> implements List<E> {
private final int maxLength;
private final List<E> underlying;
- public static <E> BoundedList<E> newArrayBacked(int maxLength) {
- return new BoundedList<>(maxLength, new ArrayList<>());
- }
-
- public static <E> BoundedList<E> newArrayBacked(int maxLength, int
initialCapacity) {
Review Comment:
1. maybe `private` is enough. the another view is that we can have
`newListBacked` for more flexible usage in the future, and the implementation
is based on the constructor taking a passed list.
```java
public static <E> BoundedList<E> newListBacked(int maxLength) {
return new BoundedList<>(maxLength, new LinkedList<>());
}
```
2. "ArrayList resizing operations don't seem to be a concern to people." ->
caller can fix it by defining "initialCapacity"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
