lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525360383
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -988,7 +989,8 @@ long getExpirationTimeForTimeout(final long timeoutMs) {
* then complete the reconciliation by updating the assignment and making
the appropriate state
* transition. Note that if any of the 2 callbacks fails, the
reconciliation should fail.
*/
- private void revokeAndAssign(SortedSet<TopicIdPartition>
assignedTopicIdPartitions,
+ private void revokeAndAssign(LocalAssignmentImpl resolvedAssignment,
Review Comment:
It was this same one
[KAFKA-16185](https://issues.apache.org/jira/browse/KAFKA-16185) thought for
handling the situation around discarding reconciliations (which is what that
rejoin check is for). But I had missed it in the review too. I just created
[KAFKA-16375](https://issues.apache.org/jira/browse/KAFKA-16375) to handle it
in a follow-up PR (probably moving away of all epochs to cover that edge case,
and identifying the rejoin simply by the member going through a transition to
join).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
