chia7712 commented on code in PR #15551: URL: https://github.com/apache/kafka/pull/15551#discussion_r1527631191
########## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ########## @@ -260,6 +260,7 @@ private void handleEvents() throws InterruptedException { if (deadlineMap.isEmpty() && (shuttingDown || interrupted)) { // If there are no more entries to process, and the queue is // closing, exit the thread. + lock.unlock(); Review Comment: it seems the lock can get freed by the `finally` block, right? https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java#L293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org