wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1528807717
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java:
##########
@@ -68,40 +68,49 @@ ConsumerRecord<Object, Object> deserialize(final
ProcessorContext<?, ?> processo
Optional.empty()
);
} catch (final Exception deserializationException) {
- final
DeserializationExceptionHandler.DeserializationHandlerResponse response;
- try {
- response = deserializationExceptionHandler.handle(
- (InternalProcessorContext<?, ?>) processorContext,
- rawRecord,
- deserializationException);
- } catch (final Exception fatalUserException) {
- log.error(
- "Deserialization error callback failed after
deserialization error for record {}",
- rawRecord,
- deserializationException);
- throw new StreamsException("Fatal user code error in
deserialization error callback", fatalUserException);
- }
+ handleDeserializationFailure(deserializationExceptionHandler,
processorContext, deserializationException, rawRecord, log,
droppedRecordsSensor);
+ return null;
Review Comment:
yeah we can add a note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
