johnnychhsu commented on PR #15550: URL: https://github.com/apache/kafka/pull/15550#issuecomment-2007003985
Thanks for the review @vamossagar12 . let me rephrase your comment to make sure that I understand you correctly. > Now, if some other thread is trying to update the config by using config(MetricConfig config), then unless that operation > doesn't go through, we can keep returning the unchanged config object. So you mean only if the `config(MetricConfig config)` works, then we need to return the updated config, right? I feel it's better to have it here, because if someone update the config, then immediately use the config as a criteria to do something else, but the config has not updated yet or somehow fails, then this could lead to a potential problem. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
