dajac commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535973164
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##########
@@ -1899,8 +1900,19 @@ public void testCommitTransactionalOffsets() throws
ExecutionException, Interrup
assertEquals(response, future.get());
}
- @Test
- public void testCommitTransactionalOffsetsWithWrappedError() throws
ExecutionException, InterruptedException {
+ private static Stream<Arguments>
testCommitTransactionalOffsetsWithWrappedErrorSource() {
+ return Stream.of(
+ Arguments.arguments(new NotEnoughReplicasException(),
Errors.COORDINATOR_NOT_AVAILABLE.code()),
+ Arguments.arguments(new NetworkException(),
Errors.COORDINATOR_LOAD_IN_PROGRESS.code())
+ );
+ }
+
+ @ParameterizedTest
+ @MethodSource("testCommitTransactionalOffsetsWithWrappedErrorSource")
Review Comment:
nit: Would it be possible to use a CsvSource with Errors,Errors? I am not
sure if CsvSource works with Enums though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
