chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536784932
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##########
@@ -203,17 +201,13 @@ public static byte[] compress(byte[] raw, CompressionType
compressionType) throw
public static ByteBuffer decompress(byte[] metrics, CompressionType
compressionType) {
ByteBuffer data = ByteBuffer.wrap(metrics);
- try (InputStream in = compressionType.wrapForInput(data,
RecordBatch.CURRENT_MAGIC_VALUE, BufferSupplier.create());
- ByteArrayOutputStream out = new ByteArrayOutputStream()) {
-
+ try (InputStream in = compressionType.wrapForInput(data,
RecordBatch.CURRENT_MAGIC_VALUE, BufferSupplier.create())) {
byte[] bytes = new byte[data.capacity() * 2];
- int nRead;
- while ((nRead = in.read(bytes, 0, bytes.length)) != -1) {
+ int nRead = in.read(bytes, 0, bytes.length);
Review Comment:
we can't remove the while loop since the `InputStream#read` does NOT
guarantee to read ALL data at once. Please take a look at API spec:
https://docs.oracle.com/javase/8/docs/api/java/io/InputStream.html#read-byte:A-int-int-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
