Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537089434


##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -283,7 +318,7 @@ public void testTopicPartitionsArgWithInternalExcluded() {
         assertEquals(expected, offsets);
     }
 
-    @ClusterTest
+    @ClusterTest(clusterType = Type.ZK)

Review Comment:
   Sure - amended the test to create consumer for polling



##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -338,6 +373,7 @@ private void assertExitCodeIsOne(String... args) {
     }
 
     private List<Row> expectedOffsetsWithInternal() {
+

Review Comment:
   Sure & reverted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to