lianetm commented on PR #15535: URL: https://github.com/apache/kafka/pull/15535#issuecomment-2018010890
Thanks both for the comments. I do like @AndrewJSchofield 's idea of having it all categorized but I ended up with several unrelated tests that seemed hard to group in a sensible way. Also the fact that @lucasbru pointed out, that I wanted to keep the way of running the abstract `BaseConsumerTest` made me keep the `PlaintextConsumerTest` as a kind of generic one. Makes sense? @lucasbru just to confirm, I did an exact copy of the contents, only changes were the additions mentioned in the comments. For the record, I think there's more room for improvement with a similar approach in other tests, I will follow up on that, probably following with the `PlaintextAdminIntegrationTest` which is in a similar (even worse) situation regarding run times. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
