brandboat commented on code in PR #15588:
URL: https://github.com/apache/kafka/pull/15588#discussion_r1539034951
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -67,13 +67,17 @@ public class TopicConfig {
"(which consists of log segments) can grow to before we will discard
old log segments to free up space if we " +
"are using the \"delete\" retention policy. By default there is no
size limit only a time limit. " +
"Since this limit is enforced at the partition level, multiply it by
the number of partitions to compute " +
- "the topic retention in bytes.";
+ "the topic retention in bytes. Additionally, retention.bytes
configuration " +
+ "operates independently of \"segment.ms\" and \"segment.byte\"
configurations. " +
+ "Moreover, it triggers the expiration of active segment if
retention.bytes is configured to zero.";
Review Comment:
Thanks for the feedback, I've address the comments in the latest commit,
please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
