dajac commented on code in PR #15492:
URL: https://github.com/apache/kafka/pull/15492#discussion_r1539495661
##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -82,7 +83,7 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance) {
TestUtils.waitUntilTrue(() => {
resultFuture.isDone && !resultFuture.isCancelled &&
!resultFuture.isCompletedExceptionally
- }, msg = s"Could not commit the offsets successfully. Last response
${resultFuture.get()}.")
+ }, msg = s"Could not commit the offsets successfully. Last response
${resultFuture.get(0, TimeUnit.MILLISECONDS)}.")
}
Review Comment:
Sorry. I meant that you could replace this entire code by
`resultFuture.get(JTestUtils.DEFAULT_MAX_WAIT_MS, TimeUnit.SECONDS)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
