showuon commented on code in PR #15549:
URL: https://github.com/apache/kafka/pull/15549#discussion_r1540405566
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -632,6 +634,7 @@ class KafkaServer(
case t: Throwable => throw new RuntimeException("Received a fatal
error while " +
"waiting for the SocketServer Acceptors to be started.", t)
}
+ info("End processing authorizer futures")
Review Comment:
> Or did you mean the log in 637 is in the wrong place ? Looks like we
should place it after L629 ?
Yes, this is what I meant. Speaking of `enableRequestProcessingFuture`, I
think we should also add logs before and after
`enableRequestProcessingFuture.join()` to avoid server hanging. WDYT?
> That inspired me, in KRaft mode we have a configuration called
server.max.startup.time.ms, maybe we can introduce the same config to Zookeeper
mode to avoid kafka server hanging forever if something goes wrong. Do you
think this is available ? If so, I'm willing to solve that !
Thanks for looking into it. If the config only works in KRaft mode, then we
cannot use that in ZK mode.
To introduce a new config needs to write a proposal (KIP) and open for
discussion and vote. Given we're going to remove ZK from Kafka soon, I don't
think it's worth adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
