nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541508048
##########
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##########
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
IntegrationTestHarness with Logg
//with includeAuthorizedOperations flag
topicResult = getTopicMetadata(client, topic, new
DescribeTopicsOptions().includeAuthorizedOperations(true))
- expectedOperations =
AclEntry.supportedOperations(ResourceType.TOPIC).asJava
+ expectedOperations = AclEntry.supportedOperations(ResourceType.TOPIC)
assertEquals(expectedOperations, topicResult.authorizedOperations)
}
+ @nowarn("cat=deprecation")
def configuredClusterPermissions: Set[AclOperation] =
- AclEntry.supportedOperations(ResourceType.CLUSTER)
+
JavaConverters.asScalaSet(AclEntry.supportedOperations(ResourceType.CLUSTER)).toSet
Review Comment:
Hello @ijuma
Sorry, I didn't find a way to use `CollectionConverters` to convert java set
to immutable scala set.
Can you give me an example?
`AclEntry.supportedOperations(ResourceType.CLUSTER).asScala` which uses
`CollectionConverters` returns `scala.collection.mutable.Set` while here we use
`scala.collection.immutable.Set`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
