chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1543099933
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ########## @@ -523,7 +523,17 @@ private RepartitionTopics prepareRepartitionTopics(final Cluster metadata) { final boolean isMissingInputTopics = !repartitionTopics.missingSourceTopicExceptions().isEmpty(); if (isMissingInputTopics) { if (!taskManager.topologyMetadata().hasNamedTopologies()) { - throw new MissingSourceTopicException("Missing source topics."); Review Comment: @mjsax Thanks for your kindful descriptions. it was very helpful for me 🙇♂️ > 1.This current code is not producing a log message: I misunderstood, thanks for your time!! I added `log.error()` through this [commit](https://github.com/apache/kafka/pull/15573/commits/fb957dbfc757d62fc5fe4ede4921ec011be96fa2). > I would propose to actually change AssignorError to contain a proper String. I agree with you. Here's how I've implemented it based on your suggestion. ([commit](https://github.com/apache/kafka/pull/15573/commits/94b9764efaf54ba2efadb16caccc2e705f553985)) I don't know all the meaning of `AssignorError codes` exactly, so I referred to the existing error logs message related with `AssignorError codes` to write the messages. What do you think? Do you think i'm on right direction? When you have some free time, Please take a look 🙇♂️. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org