gharris1727 commented on code in PR #15520: URL: https://github.com/apache/kafka/pull/15520#discussion_r1544876870
########## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ########## @@ -329,6 +329,11 @@ public static String LOGGER_CLUSTER_KEY(String namespace) { private final Map<String, Object> fencableProducerProps; private final Time time; + //VisibleForTesting + void setConfigLog(KafkaBasedLog<String, byte[]> configLog) { + this.configLog = configLog; Review Comment: I don't like this, but I think fixing it is going to also require solving the this-escape in the constructor, which looks nasty. Good enough for now, and we can address it later after EasyMock is gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org