OmniaGM commented on PR #15335: URL: https://github.com/apache/kafka/pull/15335#issuecomment-2036650723
> This change LGTM! But I think we need to have tests for the scenario you described in JIRA, to make sure it won't happen again. Could you help add some of them? Maybe add in `ReplicaManagerTest`? I added a test that ensure that offline partition shouldn't create new partition when `ReplicaManager::getOrCreatePartition` is triggered. The system test in pr https://github.com/apache/kafka/pull/15409 should also cover the full flow for this fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
