smarsching commented on code in PR #15658: URL: https://github.com/apache/kafka/pull/15658#discussion_r1552171112
########## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ########## @@ -87,8 +87,12 @@ object KafkaDockerWrapper { parser.parseArgsOrFail(args) } - private def formatStorageCmd(configsPath: Path, env: Map[String, String]): Array[String] = { - Array("format", "--cluster-id=" + env.get("CLUSTER_ID"), "-c", s"${configsPath.toString}/server.properties") + private[docker] def formatStorageCmd(configsPath: Path, env: Map[String, String]): Array[String] = { + val clusterId = env.get("CLUSTER_ID") match { + case Some(str) => str + case None => throw new RuntimeException("CLUSTER_ID environment variable is not set.") Review Comment: Sure, I just force-pushed a commit that adds this check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org