cmccabe commented on PR #15603: URL: https://github.com/apache/kafka/pull/15603#issuecomment-2037928952
I think the very first thing to do is to implement an enum for the new "recovery strategy" thing, and replace all the cases where we're using a boolean with this enum. So the boolean needs to go away. You also need to handle overrides (what happens if both strategy and unclean.leader.election.enable are set?) I think strategy takes priority. So a simple thing would be to just implement the "never" and "always" strategies for now, and not allow the middle setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
